fix: fix performance regression introduced during reader refactor #3170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2913 we added an initialization routine to the scheduler. Unfortunately, this caused a problem. It put
schedule_ranges
behind an await which means that we wouldn't schedule ranges for all files in a scan immediately. Instead, we wouldn't begin scheduling file X until we had reached nearly the last batch of file X-1. This introduced stuttering in the read path and had a significant effect on performance.The fix here moves the initialization into the dedicated scheduler thread and keeps the creation of the scheduler a synchronous task which is actually a bit simpler anyways I think.