fix

Signed-off-by: BubbleCal <[email protected]>
lancedb · BubbleCal · Dec 5, 2024 · Nov 26, 2024 · Nov 26, 2024 · Nov 27, 2024
commit a2bc89749c8feffd6d7d4c7644b1201fc4b757de
diff --git a/rust/lance-linalg/src/simd/u8.rs b/rust/lance-linalg/src/simd/u8.rs
@@ -186,7 +186,7 @@
     fn reduce_min(&self) -> u8 {
         #[cfg(target_arch = "x86_64")]
         unsafe {
-            let low = _mm_and_si128(self.0, _mm_set1_epi8(0xFF));
+            let low = _mm_and_si128(self.0, _mm_set1_epi8(0xFF as i8));
             let high = _mm_srli_si128(self.0, 8);
             let min_low = _mm_min_epu8(low, high);
             let min_low = _mm_min_epu8(min_low, _mm_srli_si128(min_low, 4));

diff --git a/rust/lance-io/src/object_store.rs b/rust/lance-io/src/object_store.rs
        &self,
        dir_path: impl Into<&Path> + Send,
        unmodified_since: Option<DateTime<Utc>>,
    ) -> Result<BoxStream<Result<ObjectMeta>>>;
 }

 #[async_trait]
        &self,
        dir_path: impl Into<&Path> + Send,
        unmodified_since: Option<DateTime<Utc>>,
    ) -> Result<BoxStream<Result<ObjectMeta>>> {
        let mut output = self.list(Some(dir_path.into()));
        if let Some(unmodified_since_val) = unmodified_since {
            output = output
    pub fn remove_stream<'a>(
        &'a self,
        locations: BoxStream<'a, Result<Path>>,
    ) -> BoxStream<Result<Path>> {
        self.inner
            .delete_stream(locations.err_into::<ObjectStoreError>().boxed())
            .err_into::<Error>()
diff --git a/rust/lance-file/src/writer/statistics.rs b/rust/lance-file/src/writer/statistics.rs

 fn cast_dictionary_arrays<'a, T: ArrowDictionaryKeyType + 'static>(
    arrays: &'a [&'a ArrayRef],
 ) -> Vec<&Arc<dyn Array>> {
    arrays
        .iter()
        .map(|x| x.as_dictionary::<T>().values())
	&self,
	dir_path: impl Into<&Path> + Send,
	unmodified_since: Option<DateTime<Utc>>,
	) -> Result<BoxStream<Result<ObjectMeta>>>;
Check warning on line 65 in rust/lance-io/src/object_store.rs GitHub Actions / linux-build (nightly) `elided lifetime has a name`
	}

	#[async_trait]
	&self,
	dir_path: impl Into<&Path> + Send,
	unmodified_since: Option<DateTime<Utc>>,
	) -> Result<BoxStream<Result<ObjectMeta>>> {
Check warning on line 74 in rust/lance-io/src/object_store.rs GitHub Actions / linux-build (nightly) `elided lifetime has a name`
	let mut output = self.list(Some(dir_path.into()));
	if let Some(unmodified_since_val) = unmodified_since {
	output = output
	pub fn remove_stream<'a>(
	&'a self,
	locations: BoxStream<'a, Result<Path>>,
	) -> BoxStream<Result<Path>> {
Check warning on line 655 in rust/lance-io/src/object_store.rs GitHub Actions / linux-build (nightly) `elided lifetime has a name`
	self.inner
	.delete_stream(locations.err_into::<ObjectStoreError>().boxed())
	.err_into::<Error>()

	fn cast_dictionary_arrays<'a, T: ArrowDictionaryKeyType + 'static>(
	arrays: &'a [&'a ArrayRef],
	) -> Vec<&Arc<dyn Array>> {
Check warning on line 489 in rust/lance-file/src/writer/statistics.rs GitHub Actions / linux-build (nightly) `elided lifetime has a name`
	arrays
	.iter()
	.map(\|x\| x.as_dictionary::<T>().values())