Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(java): introduce spotless-maven-plugin #3193

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

yanghua
Copy link
Collaborator

@yanghua yanghua commented Dec 3, 2024

No description provided.

@github-actions github-actions bot added enhancement New feature or request java labels Dec 3, 2024
@yanghua yanghua force-pushed the 3185-spotless-maven-plugin branch from d43de3a to 580ed88 Compare December 3, 2024 08:24
@yanghua
Copy link
Collaborator Author

yanghua commented Dec 3, 2024

In Java CI, when running mvn clean install, it will automatically invoke spotless-check phase.

If there is any code style issue, it will break the mvn command. The CI will fail.

Users or developers can use mvn spotless:apply to format code automatically based on Google Java Code style with a unified Spec.

In addition, we could also introduce git pre-commit-hook to make developers run this command before submitting a PR.

I believe, by introducing this plugin, the community will have a pleasing codebase. However, yes, it's unfortunate we need a one-shot reformat to initialize it.

cc @LuQQiu , FYI: Apache Iceberg, Flink, Kyuubi, and Hudi have all adopted this plugin.

@wjones127 wjones127 changed the title feat(java): introduce spotless-maven-plugin ci(java): introduce spotless-maven-plugin Dec 3, 2024
@github-actions github-actions bot added the ci Github Action or Test issues label Dec 3, 2024
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me 👍

@wjones127 wjones127 removed the enhancement New feature or request label Dec 3, 2024
@wjones127 wjones127 merged commit c5a1382 into lancedb:main Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Github Action or Test issues java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants