Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the repetition index to the miniblock write path #3208

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

westonpace
Copy link
Contributor

The repetition index is what will give us random access support when we have list data. At a high level it stores the number of top-level rows in each mini-block chunk. We can use this later to figure out which chunks we need to read.

In reality things are a little more complicated because we don't mandate that each chunk starts with a brand new row (e.g. a row can span multiple mini-block chunks). This is useful because we eventually want to support arbitrarily deep nested access. If we create not-so-mini blocks in the presence of large lists then we introduce read amplification we'd like to avoid.

@github-actions github-actions bot added the enhancement New feature or request label Dec 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 42.99674% with 175 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (5ff966d) to head (071984b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-encoding/src/encodings/logical/list.rs 10.23% 112 Missing and 2 partials ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 68.69% 30 Missing and 6 partials ⚠️
rust/lance-encoding/src/encoder.rs 18.18% 8 Missing and 1 partial ⚠️
rust/lance-encoding/src/decoder.rs 0.00% 8 Missing ⚠️
...ust/lance-encoding/src/encodings/logical/struct.rs 72.72% 6 Missing ⚠️
rust/lance-encoding-datafusion/src/zone.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3208      +/-   ##
==========================================
- Coverage   78.55%   78.44%   -0.11%     
==========================================
  Files         244      244              
  Lines       84298    84554     +256     
  Branches    84298    84554     +256     
==========================================
+ Hits        66218    66332     +114     
- Misses      15284    15417     +133     
- Partials     2796     2805       +9     
Flag Coverage Δ
unittests 78.44% <42.99%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace force-pushed the feat/2.1-repindex-miniblock-write branch from 2982346 to 071984b Compare December 10, 2024 00:24
@westonpace westonpace merged commit 10c31b3 into lancedb:main Dec 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants