Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test failure in test_fsl_packed_struct #3227

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

broccoliSpicy
Copy link
Contributor

@broccoliSpicy broccoliSpicy commented Dec 10, 2024

The current main has test failure in test_fsl_packed_struct because I introduced statistics gathering for StructDataBlock, but not statistics gathering in FixedSizeListDataBlock.

To fix this test, I can add statistics gathering(in this case, only Stat::MaxLength is needed) for FixedSizeListDataBlock.

I think the variants of FixedSizeList's child datablock can only be either fixed width datablock or another fixed size list?

This PR however only disables the packed struct encoding test for fixed size list.


after reading https://docs.rs/arrow-array/53.3.0/src/arrow_array/array/fixed_size_list_array.rs.html#133, it looks like that the child of a fixed size list can be any array type, which means to support MaxLength statistics for fixed size list data block, we need to have MaxLength statistics for all other datablock types.

Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@broccoliSpicy broccoliSpicy changed the title fix test in test_fsl_packed_struct fix: test in test_fsl_packed_struct Dec 10, 2024
@broccoliSpicy broccoliSpicy changed the title fix: test in test_fsl_packed_struct fix: test failure in test_fsl_packed_struct Dec 10, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 10, 2024
@westonpace
Copy link
Contributor

Code looks fine but fix conventional commits CI failure

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (ef9d0c2) to head (376928f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   78.45%   78.48%   +0.03%     
==========================================
  Files         244      245       +1     
  Lines       84554    84815     +261     
  Branches    84554    84815     +261     
==========================================
+ Hits        66333    66564     +231     
- Misses      15418    15439      +21     
- Partials     2803     2812       +9     
Flag Coverage Δ
unittests 78.48% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@broccoliSpicy broccoliSpicy merged commit faf776d into lancedb:main Dec 10, 2024
36 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants