fix: test failure in test_fsl_packed_struct
#3227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current main has test failure in
test_fsl_packed_struct
because I introduced statistics gathering forStructDataBlock
, but not statistics gathering inFixedSizeListDataBlock
.To fix this test, I can add statistics gathering(in this case, only
Stat::MaxLength
is needed) forFixedSizeListDataBlock
.I think the variants of
FixedSizeList's child datablock
can only be eitherfixed width datablock
or anotherfixed size list
?This PR however only disables the packed struct encoding test for
fixed size list
.after reading https://docs.rs/arrow-array/53.3.0/src/arrow_array/array/fixed_size_list_array.rs.html#133, it looks like that the child of a
fixed size list
can be any array type, which means to supportMaxLength
statistics forfixed size list data block
, we need to haveMaxLength
statistics for all otherdatablock
types.