Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable tracing for object storage #3244

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

wjones127
Copy link
Contributor

We have this on by default for local fs and in-memory. We also want this for object storage.

@github-actions github-actions bot added the enhancement New feature or request label Dec 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (99ae761) to head (d1dbbb6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-io/src/object_store.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
- Coverage   78.49%   78.49%   -0.01%     
==========================================
  Files         245      245              
  Lines       85065    85065              
  Branches    85065    85065              
==========================================
- Hits        66776    66774       -2     
- Misses      15474    15478       +4     
+ Partials     2815     2813       -2     
Flag Coverage Δ
unittests 78.49% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit c310aee into lancedb:main Dec 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants