-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: blob api documents #3247
docs: blob api documents #3247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions but seems good to me
Python APIs | ||
=========== | ||
|
||
``Lance`` is a columnar format that is specifically designed for efficient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're talking about datasets it might be more precise to refer to it as a table format here rather than a columnar format.
|
||
Indexing and Searching | ||
~~~~~~~~~~~~~~~~~~~~~~ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a sentence here like
Lance supports both nearest-neighbor searches (full text search or vector search) and full columnar scans (with or without row and column filtering)
@@ -152,7 +152,7 @@ def when_not_matched_by_source_delete(self, expr: Optional[str] = None): | |||
|
|||
|
|||
class LanceDataset(pa.dataset.Dataset): | |||
"""A dataset in Lance format where the data is stored at the given uri.""" | |||
"""A Lance Dataset in Lance format where the data is stored at the given uri.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes makes things a bit redundant. Maybe just A Lance Dataset where the data is stored at the given uri.
Closes #3160