Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Refectory Metadata class to eliminate protobuf reference. #328

Merged
merged 5 commits into from
Nov 23, 2022
Merged

[C++] Refectory Metadata class to eliminate protobuf reference. #328

merged 5 commits into from
Nov 23, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Nov 23, 2022

Code clean up and remove pb as composite member

@eddyxu eddyxu requested a review from changhiskhan November 23, 2022 07:44
changhiskhan
changhiskhan approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming this is just a code refactor right? no need to re-gen the dataset?

@eddyxu
Copy link
Contributor Author

eddyxu commented Nov 23, 2022

Yes, this is just refactory.

@eddyxu eddyxu merged commit b952b88 into main Nov 23, 2022
@eddyxu eddyxu deleted the lei/metadata_no_pb branch November 23, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan