Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full text search with limit may return an incorrect results #3284

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

BubbleCal
Copy link
Contributor

@BubbleCal BubbleCal commented Dec 23, 2024

fix #3264
this happens when limit is set and there are some docs the their estimated score is greater than threshold

Signed-off-by: BubbleCal <[email protected]>
@github-actions github-actions bot added the bug Something isn't working label Dec 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.55072% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.07%. Comparing base (022135b) to head (b7cce72).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-index/src/scalar/inverted/wand.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3284      +/-   ##
==========================================
+ Coverage   79.00%   79.07%   +0.06%     
==========================================
  Files         246      246              
  Lines       86900    87539     +639     
  Branches    86900    87539     +639     
==========================================
+ Hits        68655    69221     +566     
- Misses      15377    15454      +77     
+ Partials     2868     2864       -4     
Flag Coverage Δ
unittests 79.07% <98.55%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal marked this pull request as ready for review December 23, 2024 10:23
@wjones127 wjones127 merged commit efdea24 into lancedb:main Dec 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full text search with limit seems to be giving incorrect answer in this sample case
3 participants