Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): replace org.json with gson to resolve the jar conflict with spark 3.5.1 #3340

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

SaintBacchus
Copy link
Collaborator

@SaintBacchus SaintBacchus commented Jan 6, 2025

Now use spark 3.5.1 binary package will cause this Exception
image

The spark package contain a json jar named json-1.8.jar which also has JSONArray

@github-actions github-actions bot added bug Something isn't working java labels Jan 6, 2025
@chenkovsky
Copy link
Contributor

just another possible solution. I refactored fragment in #3307, removed dependency of json.

@SaintBacchus
Copy link
Collaborator Author

#3307 was a big change of java package. @chenkovsky can you explain the nesseary to refactor the fragment?

@chenkovsky
Copy link
Contributor

#3307 was a big change of java package. @chenkovsky can you explain the nesseary to refactor the fragment?

because lance for python has changed. I think java should be also changed sooner or later. the earlier, the less debt.

@eddyxu
Copy link
Contributor

eddyxu commented Jan 7, 2025

Curious: does this impact the minimal version of spark we can support

@SaintBacchus
Copy link
Collaborator Author

Yes,now it's only fully tested in spark 3.5.1

@SaintBacchus
Copy link
Collaborator Author

SaintBacchus commented Jan 7, 2025

I plan to support multi versions of spark later but I think now the 3.5.x was our minimal version of spark.
Otherwise some users want a old version, I will integrate as them want

@eddyxu
Copy link
Contributor

eddyxu commented Jan 7, 2025

As long as it can run with the latest databricks runtime, it is fine to me.

https://docs.databricks.com/en/release-notes/runtime/index.html

We don't have too many spark users yet, it is fine to be aggressive rn.

@eddyxu eddyxu merged commit 3823d75 into lancedb:main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants