Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Improve PyTorch dataset ergonomic #336

Merged
merged 7 commits into from
Dec 1, 2022
Merged

[Python] Improve PyTorch dataset ergonomic #336

merged 7 commits into from
Dec 1, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Nov 29, 2022 •
edited
Loading

  • Add schema() to Pytorch dataset
  • rename lance.pytorch.LanceDataset to lance.pytorch.Dataset.
  • Make pytorch.Dataset iterable for multiple times.

@eddyxu eddyxu requested a review from changhiskhan November 29, 2022 05:24
@eddyxu eddyxu added python PyTorch PyTorch support labels Nov 29, 2022
@eddyxu eddyxu assigned eddyxu and unassigned changhiskhan Nov 29, 2022
changhiskhan
changhiskhan reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the ergonomics improvement here? Supporting schema inspection?

@eddyxu eddyxu merged commit 09b1dfd into main Dec 1, 2022
@eddyxu eddyxu deleted the lei/torch_dataset branch December 1, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees

@eddyxu eddyxu

Labels
python PyTorch PyTorch support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan