Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast null arrays to the appropriate type when coercing to a table #3362

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

andrijazz
Copy link
Contributor

@andrijazz andrijazz commented Jan 9, 2025

@eddyxu @westonpace @Jay-ju Don't ask me why :) just try testing None with LanceDatasink.

See this comment: #3308 (comment)
Ref issue: #3308

@github-actions github-actions bot added the python label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending CI

@westonpace westonpace changed the title fix none fix: cast None arrays to the appropriate type when coercing to a table and the schema is known Jan 10, 2025
@westonpace westonpace changed the title fix: cast None arrays to the appropriate type when coercing to a table and the schema is known fix: cast null arrays to the appropriate type when coercing to a table and the schema is known Jan 10, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 10, 2025
@westonpace westonpace changed the title fix: cast null arrays to the appropriate type when coercing to a table and the schema is known fix: cast null arrays to the appropriate type when coercing to a table Jan 10, 2025
@westonpace westonpace merged commit 2142594 into lancedb:main Jan 10, 2025
12 checks passed
@westonpace
Copy link
Contributor

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants