Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cargo-deny #3370

Merged
merged 1 commit into from
Jan 13, 2025
Merged

ci: add cargo-deny #3370

merged 1 commit into from
Jan 13, 2025

Conversation

kemingy
Copy link
Contributor

@kemingy kemingy commented Jan 12, 2025

With two exceptions (ignored since they're not direct dependencies):

  • encoding used by lindera
  • instant used by tantivy
``` ┌─ /GitHub/lance/Cargo.lock:180:1 │ 180 │ encoding 0.2.33 registry+https://github.com/rust-lang/crates.io-index │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected │ ├ ID: RUSTSEC-2021-0153 ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0153 ├ Last release was on 2016-08-28. The [issue](https://github.com/lifthrasiir/rust-encoding/issues/127) inquiring as to the status of the crate has gone unanswered by the maintainer.
  ## Possible alternatives
  
  - [encoding_rs](https://crates.io/crates/encoding_rs)
├ Announcement: https://github.com/lifthrasiir/rust-encoding/issues/127
├ Solution: No safe upgrade is available!
├ encoding v0.2.33
  └── lindera-dictionary v0.38.1
      └── lindera v0.38.1
          ├── lance-index v0.22.0
          │   ├── lance v0.22.0
          │   │   └── lance-jni v0.22.0
          │   └── lance-jni v0.22.0 (*)
          └── lindera-tantivy v0.38.1
              └── lance-index v0.22.0 (*)

error[unmaintained]: instant is unmaintained
┌─ /GitHub/lance/Cargo.lock:276:1

276 │ instant 0.1.13 registry+https://github.com/rust-lang/crates.io-index
│ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected

├ ID: RUSTSEC-2024-0384
├ Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0384
├ This crate is no longer maintained, and the author recommends using the maintained [web-time] crate instead.

  [`web-time`]: https://crates.io/crates/web-time
├ Solution: No safe upgrade is available!
├ instant v0.1.13
  └── measure_time v0.8.3
      └── tantivy v0.22.0
          ├── lance v0.22.0
          │   └── lance-jni v0.22.0
          ├── lance-index v0.22.0
          │   ├── lance v0.22.0 (*)
          │   └── lance-jni v0.22.0 (*)
          └── lindera-tantivy v0.38.1
              └── lance-index v0.22.0 (*)
</details>

@github-actions github-actions bot added the chore label Jan 12, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (2142594) to head (ac7f2d9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3370      +/-   ##
==========================================
+ Coverage   78.44%   78.46%   +0.01%     
==========================================
  Files         250      250              
  Lines       90141    90141              
  Branches    90141    90141              
==========================================
+ Hits        70710    70727      +17     
+ Misses      16509    16491      -18     
- Partials     2922     2923       +1     
Flag Coverage Δ
unittests 78.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 changed the title chore(ci): add cargo-deny ci: add cargo-deny Jan 13, 2025
@github-actions github-actions bot added the ci Github Action or Test issues label Jan 13, 2025
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@wjones127 wjones127 merged commit 167494c into lancedb:main Jan 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ci Github Action or Test issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run cargo-deny on CI
3 participants