[Python] append column with a in-memory Pyarrow Table #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
changed the title
changhiskhan
reviewed
Dec 1, 2022
python/lance/_lib.pyx
Outdated
| def append_column( | ||
| self, | ||
| field: Field, | ||
| value: Union[Callable[[pyarrow.Table], pyarrow.Array], Expression], | ||
| value: Union[Callable[[pyarrow.Table], pyarrow.Array], Expression, pyarrow.Table], |
There was a problem hiding this comment.
if we're merging the whole table then we can't call this append_column.
There was a problem hiding this comment.
Should we create a dataset.merge method? For now, limit it to horizontal concat. But later on we can allow for appending rows and columns in one shot? Pandas has this functionality, though the pandas merge API is way too complicated. wdyt?
There was a problem hiding this comment.
ok, i will make this a separate Merge function.
| @@ -46,7 +49,9 @@ def value_func(x: pa.Table): | |||
| assert x.column_names == ["a"] | |||
| return pa.array([str(i) for i in x.column("a")]) | |||
|
|
|||
| new_dataset = dataset.append_column(pa.field("c", pa.utf8()), value_func, columns=["a"]) | |||
| new_dataset = dataset.append_column( | |||
| value_func, field=pa.field("c", pa.utf8()), columns=["a"] | |||
There was a problem hiding this comment.
you know now that i'm looking at this API, having field and columns is really going to confuse people.
There was a problem hiding this comment.
How about change columns to select ?
eddyxu
force-pushed
the
lei/hash_merge
branch
from
f58c13b to
db6d628
Compare
eddyxu
force-pushed
the
lei/py_merge_table
branch
from
074c77d to
dc14a81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #320