fix: updating schema/field metadata now retains fragments #3384
Conversation
| Operation::UpdateConfig { .. } => { | ||
| final_fragments.extend(maybe_existing_fragments?.clone()); | ||
| } |
There was a problem hiding this comment.
Maybe we should combine this with the Operation::ReserveFragments() branch since they are both metadata-only updates. That way we can keep the logic up-to-date more easily.
There was a problem hiding this comment.
good call, made this change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3384 +/- ##
==========================================
+ Coverage 78.49% 78.55% +0.05%
==========================================
Files 250 250
Lines 90243 90379 +136
Branches 90243 90379 +136
==========================================
+ Hits 70833 70993 +160
+ Misses 16505 16477 -28
- Partials 2905 2909 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| dataset | ||
| .replace_field_metadata(vec![(0, new_field_meta.clone())]) |
There was a problem hiding this comment.
I didn't actually realize we re-used UpdateConfig for schema metadata updates. I thought we just used it for the dataset config.
Co-authored-by: Will Jones <[email protected]>
Co-authored-by: Will Jones <[email protected]>
Co-authored-by: Will Jones <[email protected]>
Co-authored-by: Will Jones <[email protected]>
fixes: #3383