feat: support float16/float64 for multivector #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BubbleCal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
==========================================
- Coverage 78.49% 78.47% -0.02%
==========================================
Files 250 250
Lines 90243 90278 +35
Branches 90243 90278 +35
==========================================
+ Hits 70833 70847 +14
- Misses 16505 16524 +19
- Partials 2905 2907 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonpace
approved these changes
Jan 15, 2025
| distance_type, | ||
| ), | ||
| _ => unreachable!("missed to check query type"), | ||
| }, | ||
| } | ||
| }) | ||
| .unwrap_or(f32::NAN) |
There was a problem hiding this comment.
Do the different distance functions always return f32?
There was a problem hiding this comment.
yes, the distance is always f32
will add that in lancedb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.