Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an all null column as a metadata-only operation #3391

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

albertlockett
Copy link
Contributor

fixes: #3044

@github-actions github-actions bot added the enhancement New feature or request label Jan 17, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.27313% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (62a2256) to head (4771984).

Files with missing lines Patch % Lines
rust/lance/src/dataset/schema_evolution.rs 91.55% 0 Missing and 13 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3391      +/-   ##
==========================================
+ Coverage   78.65%   78.69%   +0.03%     
==========================================
  Files         250      250              
  Lines       90507    90734     +227     
  Branches    90507    90734     +227     
==========================================
+ Hits        71187    71401     +214     
+ Misses      16396    16393       -3     
- Partials     2924     2940      +16     
Flag Coverage Δ
unittests 78.69% <94.27%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@albertlockett albertlockett merged commit bae235d into main Jan 17, 2025
26 of 31 checks passed
@albertlockett albertlockett deleted the albert/3044 branch January 17, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support add columns with all nulls
3 participants