Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move IO tasks off of CPU runtime in merge_insert #3420

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

wjones127
Copy link
Contributor

Fixes #3419

We were using the CPU_RUNTIME, but there's a lot of IO happening here, and it wasn't configured to do that. Instead, I moved the operations onto the main runtime so it can perform the IO.

✅ I've testing this manually against S3 with the repro.

@github-actions github-actions bot added the bug Something isn't working label Jan 27, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (58c5e27) to head (26d885f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3420   +/-   ##
=======================================
  Coverage   78.81%   78.82%           
=======================================
  Files         250      250           
  Lines       91306    91305    -1     
  Branches    91306    91305    -1     
=======================================
+ Hits        71963    71970    +7     
+ Misses      16390    16380   -10     
- Partials     2953     2955    +2     
Flag Coverage Δ
unittests 78.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit 6d77d14 into lancedb:main Jan 28, 2025
25 of 27 checks passed
@wjones127 wjones127 deleted the fix/merge-insert-runtime branch January 28, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge_insert fails with panic if updating subcolumns on S3
3 participants