Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Python] Add timestamp to each manifest version. #343

Merged
merged 8 commits into from
Dec 2, 2022
Merged

[C++][Python] Add timestamp to each manifest version. #343

merged 8 commits into from
Dec 2, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Dec 1, 2022 •
edited
Loading

Closes #317

@eddyxu eddyxu self-assigned this Dec 1, 2022
@eddyxu eddyxu marked this pull request as ready for review December 1, 2022 20:16
@eddyxu eddyxu requested a review from changhiskhan December 1, 2022 20:16
@eddyxu eddyxu added python c++ C++ issues labels Dec 1, 2022
@eddyxu eddyxu changed the title Add timestamp to each manifest version. [C++][Python] Add timestamp to each manifest version. Dec 1, 2022
changhiskhan
changhiskhan approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending CI

@eddyxu eddyxu force-pushed the lei/version_timestamp branch from bd630d4 to 07ff61c Compare December 1, 2022 23:26
@eddyxu eddyxu merged commit 0f3d9f5 into main Dec 2, 2022
@eddyxu eddyxu deleted the lei/version_timestamp branch December 2, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees

@eddyxu eddyxu

Labels
c++ C++ issues python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attach create timestamp for each dataset version
2 participants
@eddyxu @changhiskhan