New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] add Dataset::Make(string) API #346

Merged

eddyxu merged 1 commit into main from lei/dataset_open_with_uri

Dec 5, 2022

Contributor

eddyxu commented Dec 3, 2022

Allow creating LanceDataset directly from a qualified URI to simplify the caller code.
Correctly set protobuf generation code to the relative path of cpp source code, making the core cpp project available as cmake subproject to be built.


          add Dataset::Make(string) API

efaad7d

eddyxu requested a review from changhiskhan

December 3, 2022 19:58

eddyxu self-assigned this

changhiskhan approved these changes

View reviewed changes

eddyxu merged commit d3edb17 into main

eddyxu deleted the lei/dataset_open_with_uri branch

December 5, 2022 02:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet