Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUCKDB] Read a special version of dataset #350

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[DUCKDB] Read a special version of dataset #350

merged 2 commits into from
Dec 5, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Dec 5, 2022

Closes #349

@eddyxu eddyxu requested a review from changhiskhan December 5, 2022 06:43
@eddyxu eddyxu marked this pull request as ready for review December 5, 2022 06:43
@eddyxu eddyxu added c++ C++ issues duckdb labels Dec 5, 2022
@eddyxu eddyxu self-assigned this Dec 5, 2022
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the replacement scan still work?

@eddyxu
Copy link
Contributor Author

eddyxu commented Dec 5, 2022

Yes, it still works for the case w/o version

❯ ./duckdb -unsigned
v0.6.0 2213f9c946
Enter ".help" for usage hints.
D FORCE INSTALL './lance.duckdb_extension';
D LOAD 'lance';
D select _pk FROM 's3://eto-public/datasets/oxford_pet/oxford_pet.lance' LIMIT 10;
┌───────┐
│  _pk  │
│ int16 │
├───────┤
│     0 │
│     1 │
│     2 │
│     3 │
│     4 │
│     5 │
│     6 │
│     7 │
│     8 │
│     9 │
└───────┘

@eddyxu eddyxu merged commit 1395b1e into main Dec 5, 2022
@eddyxu eddyxu deleted the lei/read_version branch December 5, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ C++ issues duckdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DuckDB] lance_scan supports specifying a version
2 participants