Add function to get version as of a certain date. Also formatting #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Dec 16, 2022
python/lance/__init__.py
Outdated
| return _get_versioned_dataset(filesystem, uri, version) | ||
|
|
||
|
|
||
| def _is_versioned(filesystem, uri): |
There was a problem hiding this comment.
not sure what does this mean. it checks whether latest manifest exist? why it is related to versioned?
Or you mean it is a plain dataset? Should we just rename this function to is_plain_dataset?
There was a problem hiding this comment.
i'm just refactoring what you had in there
There was a problem hiding this comment.
sure i can call this "is_plain_dataset"
python/lance/__init__.py
Outdated
| return not (filesystem.get_file_info(manifest).type == pa.fs.FileType.NotFound) | ||
|
|
||
|
|
||
| def _get_versioned_dataset(filesystem, uri, version): |
There was a problem hiding this comment.
let's add type annotations here?
python/lance/__init__.py
Outdated
| return _dataset_plain(uri, filesystem=filesystem, **kwargs) | ||
|
|
||
| if asof is not None: | ||
| ds = dataset(uri, version, filesystem=filesystem, **kwargs) |
There was a problem hiding this comment.
use _get_versioned_dataset here? to reduce another I/O to check is_plain_dataset ?
eddyxu
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.