Changhiskhan/datadiff #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
approved these changes
Dec 17, 2022
| @@ -18,7 +18,7 @@ | |||
| import pytz | |||
|
|
|||
| import lance | |||
| from lance.util.versioning import get_version_asof | |||
| from lance.util.versioning import get_version_asof, compute_metric, diff, LanceDiff, RowDiff, ColumnDiff | |||
python/lance/util/versioning.py
Outdated
| return pd.concat(results) | ||
|
|
||
|
|
||
| def diff(uri, start_version: int, end_version: int) -> LanceDiff: |
There was a problem hiding this comment.
should we change the parameters to v1 and v2?
start/end makes me think this is find all versions from v1 to v2. like git log v1..v2
changhiskhan
force-pushed
the
changhiskhan/datadiff
branch
from
401488b to
6b5b885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #379
Ignore the "compute_metric" stuff in this PR just look at the data diff changes