Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUST] Initialize read support in Rust. #401

Merged
merged 13 commits into from
Jan 5, 2023
Merged

[RUST] Initialize read support in Rust. #401

merged 13 commits into from
Jan 5, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jan 5, 2023 •
edited
Loading

With this PR, you can run lq inspect over local lance datasets.

@eddyxu eddyxu self-assigned this Jan 5, 2023
@eddyxu eddyxu requested a review from changhiskhan January 5, 2023 08:47
@eddyxu eddyxu marked this pull request as ready for review January 5, 2023 08:47
changhiskhan
changhiskhan reviewed Jan 5, 2023
View reviewed changes
protos/format.proto
@@ -120,6 +122,7 @@ enum Encoding {
PLAIN = 1;
VAR_BINARY = 2;
DICTIONARY = 3;
RLE = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's exciting

@eddyxu eddyxu merged commit 3a4bdee into main Jan 5, 2023
@eddyxu eddyxu deleted the lei/rust2 branch January 5, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees

@eddyxu eddyxu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan