Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing logical type conversions #404

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Add missing logical type conversions #404

merged 4 commits into from
Jan 6, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jan 6, 2023

No description provided.

@eddyxu eddyxu marked this pull request as ready for review January 6, 2023 04:11
changhiskhan
changhiskhan approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 extra test case if you get a chance

rust/src/datatypes.rs
@@ -312,6 +394,40 @@ mod tests {
}
}

#[test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test case for list-of-list-of-float (just to make sure bounding boxes would work well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@eddyxu eddyxu merged commit 9052d64 into main Jan 6, 2023
@eddyxu eddyxu deleted the lei/logical_types branch January 6, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan