Recursively set dictionaries in struct fields #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsilvestrin
changed the title
added 2 commits
March 8, 2023 08:58
eddyxu
reviewed
Mar 8, 2023
| @@ -301,7 +303,7 @@ impl Field { | |||
| assert!(self.data_type().is_dictionary()); | |||
| self.dictionary = Some(Dictionary { | |||
| offset: 0, | |||
There was a problem hiding this comment.
Should set the offset as well?
There was a problem hiding this comment.
Added a comment clarifying when / how these fields are set
rust/src/datatypes.rs
Outdated
| } | ||
| DataType::List(values) => { | ||
| // should this be self.children[0]? | ||
| let mut f = Field::try_from(values.as_ref()).unwrap(); |
There was a problem hiding this comment.
change to use self.children[0]?
I might prefer keep such case unhandled instead of leaving code like this.
There was a problem hiding this comment.
rust/src/datatypes.rs
Outdated
| let mut f = Field::try_from(values.as_ref()).unwrap(); | ||
| let list_arr = arr.as_any().downcast_ref::<LargeListArray>().unwrap(); | ||
| f.set_dictionary(list_arr.values()); | ||
| } | ||
| _ => { | ||
| // Add nested struct support. |
There was a problem hiding this comment.
Remove the comments? Any other edge case left?
There was a problem hiding this comment.
list support was moved to their own pr: https://github.com/eto-ai/lance/pull/664/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.