Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] sampling over matrix. #666

Merged
merged 3 commits into from
Mar 8, 2023
Merged

[Rust] sampling over matrix. #666

merged 3 commits into from
Mar 8, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Mar 8, 2023

No description provided.

@eddyxu eddyxu requested a review from changhiskhan March 8, 2023 19:59
@eddyxu eddyxu marked this pull request as ready for review March 8, 2023 19:59
@eddyxu eddyxu requested a review from gsilvestrin March 8, 2023 20:03
gsilvestrin
gsilvestrin approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@gsilvestrin gsilvestrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddyxu eddyxu merged commit 0341c04 into main Mar 8, 2023
@eddyxu eddyxu deleted the lei/matrix_sample branch March 8, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

@gsilvestrin gsilvestrin gsilvestrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddyxu @gsilvestrin @changhiskhan