Bugfix for BinaryEncoder positions #698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging multiple arrays, BinaryEncoder creates a array of positions/offsets that it is too big.
For instance in the following array:
Each sub-array has its own offset array. Since each array has 4 elements the offset array has 5 elements
When BinaryEncoder merge all sub-arrays into a single Array, it creates an array of length 12 (4*3) but an offset array with 15 elements
This PR makes it create the correct offset array with 13 elements