Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Use folked sqlparser to unblock rust crate release #732

Merged
merged 2 commits into from
Mar 24, 2023
Merged

[Rust] Use folked sqlparser to unblock rust crate release #732

merged 2 commits into from
Mar 24, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Mar 24, 2023

Published a forked version of sqlparser-lance, which means that we can use crate version of sqlparser instead of git version as dependency, which prevents cargo publish.

@eddyxu eddyxu requested a review from changhiskhan March 24, 2023 23:17
@eddyxu eddyxu self-assigned this Mar 24, 2023
@eddyxu eddyxu added the rust Rust related tasks label Mar 24, 2023
@eddyxu
Copy link
Contributor Author

eddyxu commented Mar 24, 2023 •
edited
Loading

Closes #726

Verified with

cargo t
cargo publish --dry-run

@eddyxu eddyxu mentioned this pull request Mar 24, 2023
Closed
@eddyxu eddyxu requested a review from gsilvestrin March 24, 2023 23:25
@eddyxu eddyxu merged commit 27b4967 into main Mar 24, 2023
@eddyxu eddyxu deleted the lei/rust_release_fix branch March 24, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

@gsilvestrin gsilvestrin Awaiting requested review from gsilvestrin

Assignees

@eddyxu eddyxu

Labels
rust Rust related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan