Restore the custom build script for pyarrow #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For local development it's much faster to be able do python setup.py develop So we use the previous thirdparty build script to build pyarrow against system libarrow that we installed to enable liblance build. The main change in this PR is changing the arrow ref being checked out. By default this builds pyarrow 8.0.0.devXXX, which fails the pylance requirement of pyarrow>=8,<9. Instead we use the 8.0.1 tag in pyarrow
eddyxu
approved these changes
Aug 5, 2022
eddyxu
pushed a commit
that referenced
this pull request
Aug 6, 2022
For local development it's much faster to be able do python setup.py develop So we use the previous thirdparty build script to build pyarrow against system libarrow that we installed to enable liblance build. The main change in this PR is changing the arrow ref being checked out. By default this builds pyarrow 8.0.0.devXXX, which fails the pylance requirement of pyarrow>=8,<9. Instead we use the 8.0.1 tag in pyarrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For local development it's much faster to be able do python setup.py develop
So we use the previous thirdparty build script to build pyarrow against
system libarrow that we installed to enable liblance build.
The main change in this PR is changing the arrow ref being checked out. By
default this builds pyarrow 8.0.0.devXXX, which fails the pylance requirement
of pyarrow>=8,<9. Instead we use the 8.0.1 tag in pyarrow