Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format string for the assertion #866

Merged
merged 1 commit into from
May 15, 2023
Merged

Add format string for the assertion #866

merged 1 commit into from
May 15, 2023

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented May 15, 2023 •
edited
Loading

ref #856

Add a custom assertion error message.
Should be useful for debugging.

@haoxins haoxins force-pushed the add-verbose-log branch from 9ba4f72 to 5f0d0c7 Compare May 15, 2023 08:56
changhiskhan
changhiskhan approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@changhiskhan
Copy link
Contributor

the windows build error seems to be permissions issue. i'm going to force merge this

@changhiskhan changhiskhan merged commit 54bf95b into lancedb:main May 15, 2023
@haoxins haoxins deleted the add-verbose-log branch May 15, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoxins @changhiskhan