Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-860: Create a scanner from fragments #869

Merged
merged 2 commits into from
May 15, 2023
Merged

GH-860: Create a scanner from fragments #869

merged 2 commits into from
May 15, 2023

Conversation

wjones127
Copy link
Contributor

Initial implementation of LanceScanner.from_fragments() for Python. Supports Iterable[LanceFragment] at the interface, but leaves actually using an iterator as a TODO.

Closes #860.

@wjones127 wjones127 mentioned this pull request May 15, 2023
Closed
@wjones127 wjones127 requested a review from eddyxu May 15, 2023 18:48
@wjones127 wjones127 marked this pull request as ready for review May 15, 2023 18:48
eddyxu
eddyxu approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@wjones127 wjones127 merged commit 049c6fd into main May 15, 2023
@wjones127 wjones127 deleted the GH-860-scanner-from-fragments branch May 15, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] Implement Scanner::from_fragments() to initialize a scanner from sub-set of fragments
2 participants
@wjones127 @eddyxu