Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting offset without limit #892

Merged
merged 3 commits into from
May 22, 2023
Merged

feat: allow setting offset without limit #892

merged 3 commits into from
May 22, 2023

Conversation

wjones127
Copy link
Contributor

Closes #891.

eddyxu
eddyxu reviewed May 22, 2023
View reviewed changes
rust/src/dataset/scanner.rs Outdated Show resolved Hide resolved
rust/src/dataset/scanner.rs Show resolved Hide resolved
eddyxu
eddyxu approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. LGTM. Pending CI.

@wjones127 wjones127 merged commit 35aaf2f into main May 22, 2023
@wjones127 wjones127 deleted the wjones127/891-limit-offset branch May 22, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting offset but not limit returns zero rows
2 participants
@wjones127 @eddyxu