Check an object store is on local file system #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsilvestrin
reviewed
May 30, 2023
rust/src/io/object_store.rs
Outdated
| @@ -41,7 +41,7 @@ use super::object_reader::ObjectReader; | |||
| pub struct ObjectStore { | |||
| // Inner object store | |||
| pub inner: Arc<dyn OSObjectStore>, | |||
| scheme: String, | |||
| pub scheme: String, | |||
There was a problem hiding this comment.
Does this need to be public if we have is_local?
There was a problem hiding this comment.
ok, i can make it private for now
gsilvestrin
reviewed
May 30, 2023
| @@ -147,6 +147,11 @@ impl ObjectStore { | |||
| } | |||
| } | |||
|
|
|||
| /// Returns true if the object store pointed to a local file system. | |||
| pub fn is_local(&self) -> bool { | |||
| self.scheme == "file" | |||
There was a problem hiding this comment.
new_from_path creates a store with scheme flle - I never figured out why, but can this be a problem here?
There was a problem hiding this comment.
new_from_path creates a local object store, right? that's the correct expectation?
There was a problem hiding this comment.
I mean there is a type there - flle instead of file, but I don't know why:
lance/rust/src/io/object_store.rs
Line 115 in e4aa45c
There was a problem hiding this comment.
oh, this appears to be a typo. lemme fix in this PR then
wjones127
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.