Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argmin benchmark #927

Merged
merged 1 commit into from
Jun 1, 2023
Merged

argmin benchmark #927

merged 1 commit into from
Jun 1, 2023

Conversation

chebbyChefNEQ
Copy link
Contributor

partially addresses #762

I'm adding argmin first because it's a major hotspot when constructing index. See attached perf report.

Screenshot from 2023-05-31 23-14-40

I extracted create_file function from vector_index bench, ran it in a binary, and recorded with perf. The result shows that we spend 17% of the time in argmin function.

The total time of the program is 14s + some change. It took 1+ second alone to generate and write the data to disk before index begone. Discounting the data generation overhead, we can safely say that argmin is about 20% of the time spent when build an index.

I will follow up with AVX and Neon implementation of argmin.

@chebbyChefNEQ chebbyChefNEQ force-pushed the rmeng/vector-index-create-bench branch from 211805c to 16e18ca Compare June 1, 2023 04:38
@chebbyChefNEQ chebbyChefNEQ force-pushed the rmeng/vector-index-create-bench branch from 16e18ca to 4ada624 Compare June 1, 2023 04:50
@chebbyChefNEQ chebbyChefNEQ merged commit ed68738 into main Jun 1, 2023
@chebbyChefNEQ chebbyChefNEQ deleted the rmeng/vector-index-create-bench branch June 1, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants