Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Use lance local object store #959

Merged
merged 19 commits into from
Jun 9, 2023
Merged

[Rust] Use lance local object store #959

merged 19 commits into from
Jun 9, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 9, 2023

No description provided.

@eddyxu eddyxu requested review from wjones127 and chebbyChefNEQ June 9, 2023 18:47
@eddyxu eddyxu marked this pull request as ready for review June 9, 2023 18:47
wjones127
wjones127 reviewed Jun 9, 2023
View reviewed changes
rust/src/dataset.rs Outdated Show resolved Hide resolved
wjones127
wjones127 reviewed Jun 9, 2023
View reviewed changes
rust/src/dataset.rs Outdated Show resolved Hide resolved
wjones127
wjones127 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. It seems to allow spaces and some other characters like : in paths. Emojis aren't allowed in paths though, but IMO that's fine.

@eddyxu eddyxu merged commit 39f404f into main Jun 9, 2023
@eddyxu eddyxu deleted the lei/object_store_path branch June 9, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chebbyChefNEQ chebbyChefNEQ chebbyChefNEQ approved these changes

@wjones127 wjones127 wjones127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddyxu @wjones127 @chebbyChefNEQ