Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Allow to provide pre-existing IVF_PQ centroids during index creation #963

Merged
merged 5 commits into from
Jun 12, 2023
Merged

[Rust] Allow to provide pre-existing IVF_PQ centroids during index creation #963

merged 5 commits into from
Jun 12, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 11, 2023 •
edited
Loading

Allow create IVF_PQ index with pre-populated kmean centroids.

@eddyxu eddyxu marked this pull request as ready for review June 11, 2023 23:57
chebbyChefNEQ
chebbyChefNEQ approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@chebbyChefNEQ chebbyChefNEQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a test for these two new path.

@eddyxu eddyxu merged commit 8165572 into main Jun 12, 2023
@eddyxu eddyxu deleted the lei/external_kmeans branch June 12, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chebbyChefNEQ chebbyChefNEQ chebbyChefNEQ approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @chebbyChefNEQ