Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coco benchmarks for lance and parquet formats #97

Merged
merged 9 commits into from
Aug 16, 2022
Merged

Coco benchmarks for lance and parquet formats #97

merged 9 commits into from
Aug 16, 2022

Conversation

changhiskhan
Copy link
Contributor

@changhiskhan changhiskhan commented Aug 11, 2022 •
edited
Loading

@changhiskhan changhiskhan requested a review from eddyxu August 11, 2022 23:09
eddyxu
eddyxu approved these changes Aug 13, 2022
View reviewed changes
python/benchmarks/bench_utils.py
return f"{base_uri}/{dataset_name}{('_' + flavor) if flavor else ''}.{fmt}"


class BenchmarkSuite:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there something similar in pytest or other library ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, there are a bunch. was easier to just write something quick for our use case here.

We could switch to asv at some point: https://asv.readthedocs.io/en/stable/index.html

python/benchmarks/coco.py Outdated

import argparse
import click
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@changhiskhan changhiskhan marked this pull request as ready for review August 13, 2022 01:10
@changhiskhan changhiskhan force-pushed the changhiskhan/updated-benchmarks branch from 507f84c to d887910 Compare August 13, 2022 01:11
@changhiskhan
Copy link
Contributor Author

let me wait for #96 to be resolved first so filter_data lance can work properly

@changhiskhan changhiskhan force-pushed the changhiskhan/updated-benchmarks branch from 5c6f940 to d0c28ba Compare August 14, 2022 20:28
@eddyxu eddyxu linked an issue Aug 15, 2022 that may be closed by this pull request
Establish performance baseline #12
Closed
@changhiskhan changhiskhan force-pushed the changhiskhan/updated-benchmarks branch from d0c28ba to b7faa32 Compare August 15, 2022 19:09
@changhiskhan changhiskhan force-pushed the changhiskhan/updated-benchmarks branch from 0e02cbb to d7393d8 Compare August 16, 2022 04:02
@changhiskhan changhiskhan merged commit c11939d into main Aug 16, 2022
@changhiskhan changhiskhan deleted the changhiskhan/updated-benchmarks branch August 16, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Establish performance baseline
2 participants
@changhiskhan @eddyxu