Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hibernate #6

Closed
wants to merge 11 commits into from
Closed

Remove Hibernate #6

wants to merge 11 commits into from

Conversation

petecheslock
Copy link
Contributor

Remove org.hibernate from the Vet entity. Return the Vet model so that a many-to-many relationship exists between the Vet and Specialty entities

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems 🐌 4 new
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

Performance problems

🐌 New problems detected (4)

N plus 1 SQL query
Description

org/springframework/samples/petclinic/MySqlIntegrationTests#testFindAll[1] contains 6 occurrences of SQL: select s1_0.vet_id,s1_1.id,s1_1.name from vet_specialties s1_0 join specialties s1_1 on s1_1.id=s1_0.specialty_id where s1_0.vet_id=?

Field Value
Rule n-plus-one-query
Impact domain Performance
View in AppMap
Stack trace
N plus 1 SQL query
Description

org/springframework/samples/petclinic/PetClinicIntegrationTests#testFindAll[1] contains 6 occurrences of SQL: select s1_0.vet_id,s1_1.id,s1_1.name from vet_specialties s1_0 join specialties s1_1 on s1_1.id=s1_0.specialty_id where s1_0.vet_id=?

Field Value
Rule n-plus-one-query
Impact domain Performance
View in AppMap
Stack trace
N plus 1 SQL query
Description

org/springframework/samples/petclinic/PostgresIntegrationTests#testFindAll[1] contains 6 occurrences of SQL: select s1_0.vet_id,s1_1.id,s1_1.name from vet_specialties s1_0 join specialties s1_1 on s1_1.id=s1_0.specialty_id where s1_0.vet_id=?

Field Value
Rule n-plus-one-query
Impact domain Performance
View in AppMap
Stack trace
N plus 1 SQL query
Description

org/springframework/samples/petclinic/service/ClinicServiceTests#shouldFindVets[1] contains 6 occurrences of SQL: select s1_0.vet_id,s1_1.id,s1_1.name from vet_specialties s1_0 join specialties s1_1 on s1_1.id=s1_0.specialty_id where s1_0.vet_id=?

Field Value
Rule n-plus-one-query
Impact domain Performance
View in AppMap
Stack trace

@petecheslock petecheslock force-pushed the feat/remove-hibernate branch from 29ab2aa to 88b8ac3 Compare January 5, 2024 20:16
@petecheslock petecheslock force-pushed the main branch 2 times, most recently from f83087a to 65d662c Compare May 15, 2024 19:12
@petecheslock petecheslock deleted the feat/remove-hibernate branch May 15, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants