Appland v2.9.5 #8
Open
+251
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using navbar variables and general variables color, about Tabs. Dedicated variables has been added.
We are already doing that for core preferences (plain Spree::Config). This commit also allows to use stub_spree_preferences into stores and extensions that define their own configuration classes, like Spree::Auth::Config in solidus_auth_devise for example.
it's already the default value
Noticed that the custom sass `@function very-light` doesn't work properly and this fact is generating display issues, both in tables with actions, and in components such as Taxonomies.
Temporary fix for solidusio#3374
Sprockets 4 uses manifest files[1], and the default manifest.js links `app/assets/images`. To prevent it from crashing due to the directory not being present, the easiest solution is to create an empty `app/assets/images` directory. [1]: https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs
The method was only "unused" within the Solidus codebase, but extensions and apps were relying on it. This reverts commit d82fb56.
It mixes different levels of configuration and just forwards to its class level counterpart.
…oval-and-add-a-deprecation Revert method removal and replace it with a deprecation
Was removed as part of solidusio#3081, but not being private it's better to keep it around with a deprecation for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.