Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove fine tuning support #355

Merged
merged 12 commits into from
Feb 13, 2025
Merged

Conversation

hrnn
Copy link
Member

@hrnn hrnn commented Feb 7, 2025

We are discontinuing support for fine-tuning, as va.landing.ai no longer offers this feature. However, we will continue to support custom object detection model training on LandingLens (app.landing.ai).

Warning

This is a breaking change for old chats that used fine-tuned models.

@hrnn hrnn self-assigned this Feb 7, 2025
@hrnn hrnn marked this pull request as ready for review February 10, 2025 16:38
Copy link
Member

@Dayof Dayof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old chats might be calling the functions with fine_tune_id, isn't it better to be backward compatible and check if fine_tune_id is set, print a warning saying that this arg is deprecated and add the deployment_id as a separate arg?

@CamiloInx
Copy link
Member

old chats might be calling the functions with fine_tune_id, isn't it better to be backward compatible and check if fine_tune_id is set, print a warning saying that this arg is deprecated and add the deployment_id as a separate arg?

Agree. We should probably don't modify the fine_tune_id param, and only use it for the custom_od from now on.

Copy link
Member

@Dayof Dayof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test to make sure that fine_tune_id still acessible

Copy link
Member

@Dayof Dayof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that fine tune id is still accessible to all the tests that used to call the fine tune logic, not only one

vision_agent/tools/tools.py Show resolved Hide resolved
vision_agent/utils/video_tracking.py Show resolved Hide resolved
Copy link
Member

@camiloaz camiloaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand these changes very well. we are removing the code that processes fine_tune_id but we don't remove the fine_tune_id parameter from the function signatures. which means that the code will receive the parameter, raise a deprecation warning but still will not use the parameter for anything. i don't think this makes sense.

why are we concerned with making this change backwards compatible? we can bump a major version if we want to, people using the vision-agent can decide whether to upgrade the version or not.

@hrnn
Copy link
Member Author

hrnn commented Feb 12, 2025

Hi @Dayof @CamiloInx
Recently we agreed with @dillonalaird to don't make these changes backward compatible.

Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrnn hrnn merged commit 17c7007 into landing-ai:main Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants