Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10 requires composer 2.3.6 or higher #31

Closed
gitressa opened this issue Jul 15, 2022 · 6 comments · Fixed by #105
Closed

Drupal 10 requires composer 2.3.6 or higher #31

gitressa opened this issue Jul 15, 2022 · 6 comments · Fixed by #105
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@gitressa
Copy link
Contributor

gitressa commented Jul 15, 2022

Drupal 10 requires composer 2.3.6 or higher so perhaps Composer should get updated? See also thinktandem/drupal-contributions#69.

@gitressa gitressa added the bug Something isn't working label Jul 15, 2022
@StijnHaulotte
Copy link

Actualy i thionk it's also good fro drupal 9.0 to habe the default composer at least at 2.2 because of the allowed plugins

@gitressa
Copy link
Contributor Author

gitressa commented Sep 2, 2022

It already is, though -- but getting it to 2.3.5 or higher would also be great :-)

$ lando composer --version
Composer version 2.2.12 2022-04-13 16:42:25

@gitressa gitressa changed the title Drupal 10 requires composer 2.3.5 or higher Drupal 10 requires composer 2.3.6 or higher Sep 17, 2022
@gitressa
Copy link
Contributor Author

The requirement has been updated to 2.3.6: https://www.drupal.org/docs/system-requirements/composer-requirements

@reynoldsalec
Copy link
Member

Guessing this may be even higher now; good issue for a contributor to check out! We should probably update the defaults in the PHP images we use, ex: https://github.com/lando/php/blob/main/images/8.1-fpm/Dockerfile#L73, although if we do this it would require us to revise a bunch of the tests across all our PHP-using recipes to check for that version of Composer, so it could be a bit of an undertaking.

@reynoldsalec
Copy link
Member

reynoldsalec commented Apr 2, 2024

Perhaps the best approach here is to use 2-latest within the builder files for the Drupal recipe...it would be good to verify how this is working now...strange that we didn't use 2-latest right now. If we do that, it would probably be worthwhile to update Composer across all recipes in Drupal and our other Drupal-y related recipes (Acquia/Pantheon) and even other PHP recipes (WordPress, Laravel)...create some more tickets for that (thanks @StephanieF for the recommendation). This probably reinforces that we should update our underlying PHP default Composer versions as well.

@reynoldsalec reynoldsalec self-assigned this Apr 2, 2024
@reynoldsalec
Copy link
Member

I should ping @StephanieF on the Acquia issue coming out of this!

@reynoldsalec reynoldsalec moved this from Todo to In Progress in Lando Plugin Contribution Board Apr 15, 2024
reynoldsalec added a commit that referenced this issue Apr 15, 2024
reynoldsalec added a commit that referenced this issue Apr 16, 2024
* #31: Use 2-latest as composer_version for Drupal 9 and 10.

* #31: Add Changelog.

* #31: Update docs to reflect composer version change.

* #31: Updated version test for composer.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lando Plugin Contribution Board Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

3 participants