generated from langchain-ai/integration-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bedrock token count and IDs for Anthropic models #341
Merged
3coins
merged 10 commits into
langchain-ai:main
from
michaelnchin:anthropic-tokens-tempfix
Feb 7, 2025
Merged
Fix Bedrock token count and IDs for Anthropic models #341
3coins
merged 10 commits into
langchain-ai:main
from
michaelnchin:anthropic-tokens-tempfix
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelnchin
Thanks for submitting these changes. A question about the version checks, and a suggestion to use of warnings rather than logger statements.
3coins
reviewed
Feb 6, 2025
Co-authored-by: Piyush Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314
The
get_num_tokens()
andget_token_ids()
methods ofBedrockLLM
andChatBedrock
currently fail when used with Anthropic models andanthropic>=0.39.0
installed.In such scenarios, this PR fixes
get_num_tokens()
andget_token_ids()
by falling back to the base class implementations inBaseLanguageModel
and inBaseChatModel
, which use the HuggingFace GPT2 Tokenizer.If
anthropic<=0.38.0
(and other requirements) are present instead, the Anthropic SDK token methods will continue to be used as normal.Note about tokenizer accuracy:
The GPT2 and Anthropic SDK tokenizers (see here) both may produce inaccurate token estimates for Claude 3 and 3.5 models. To obtain a more accurate estimate, Anthropic recommends using the new Count Message Tokens API. For example:
As another alternative, you can implement your own token counter method, and pass this using
custom_get_token_ids
when initializing the model. This will override both the GPT2 and Anthropic tokenizers.