Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Runnable.with_listeners() #12549

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Add Runnable.with_listeners() #12549

merged 5 commits into from
Oct 31, 2023

Conversation

nfcampos
Copy link
Collaborator

  • This binds start/end/error listeners to a runnable, which will be called with the Run object

@nfcampos nfcampos requested a review from hinthornw October 30, 2023 12:43
@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 10:19am

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Oct 30, 2023
eyurtsev
eyurtsev approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation would be useful to explain what the goal of the code is and when one might want to use it

hinthornw
hinthornw approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@hinthornw hinthornw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Works for me!

@nfcampos nfcampos force-pushed the nc/runnable-with-listeners branch from 5c52b10 to 1f482e0 Compare October 31, 2023 10:19
@nfcampos nfcampos merged commit 2f563ce into master Oct 31, 2023
@nfcampos nfcampos deleted the nc/runnable-with-listeners branch October 31, 2023 11:04
xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
@nfcampos @xieqihui
Add Runnable.with_listeners() (langchain-ai#12549)
9856eb9 
- This binds start/end/error listeners to a runnable, which will be
called with the Run object
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@nfcampos
Add Runnable.with_listeners() (langchain-ai#12549)
669229a 
- This binds start/end/error listeners to a runnable, which will be
called with the Run object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

@hinthornw hinthornw hinthornw approved these changes

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfcampos @eyurtsev @hinthornw