Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for both linting and formatting in langchain-cli. #12672

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

obi1kenobi
Copy link
Collaborator

Prior to this PR, ruff was used only for linting and not for formatting, despite the names of the commands. This PR makes it be used for both linting code and autoformatting it.

Prior to this PR, `ruff` was used only for linting and not for formatting, despite the names of the commands. This PR makes it be used for both linting code and autoformatting it.
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 8:41pm

@obi1kenobi obi1kenobi requested a review from efriis October 31, 2023 20:41
@dosubot dosubot bot added the 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Oct 31, 2023
@efriis efriis merged commit e8b9936 into master Oct 31, 2023
@efriis efriis deleted the pg/both-lint-and-format-cli-with-ruff branch October 31, 2023 20:52
xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
…hain-ai#12672)

Prior to this PR, `ruff` was used only for linting and not for
formatting, despite the names of the commands. This PR makes it be used
for both linting code and autoformatting it.
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
…hain-ai#12672)

Prior to this PR, `ruff` was used only for linting and not for
formatting, despite the names of the commands. This PR makes it be used
for both linting code and autoformatting it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants