Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: chat message history mypy fixes #17350

Closed
wants to merge 1 commit into from

Conversation

h0rv
Copy link
Contributor

@h0rv h0rv commented Feb 9, 2024

Description: Fixed type: ignore's for mypy for the BaseChatMessageHistory class.
Issue: Remove "type: ignore" comments #17048

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 1:19am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🤖:improvement Medium size change to existing code to handle new use-cases 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations labels Feb 9, 2024
@h0rv h0rv force-pushed the chat-message-mypy branch from 2f617af to 14279da Compare February 13, 2024 03:13
@h0rv h0rv force-pushed the chat-message-mypy branch from 14279da to f16f2a2 Compare February 26, 2024 01:19
@h0rv h0rv closed this Feb 26, 2024
@h0rv h0rv deleted the chat-message-mypy branch February 26, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: elasticsearch Primarily related to elastic/elasticsearch integrations 🤖:improvement Medium size change to existing code to handle new use-cases size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant