langchain: add Jina Reranker in retrievers module #19406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoanFM
force-pushed
the
feat-jina-rerank
branch
3 times, most recently
from
55809bf to
1c180c1
Compare
JoanFM
force-pushed
the
feat-jina-rerank
branch
from
1c180c1 to
9d2a1a3
Compare
|
@JoanFM feel free to ping when it's ready for review! |
dosubot
bot
added
the
size:L
Hey @baskaryan , This is now ready for review. |
dosubot
bot
added
Ɑ: retriever
…into feat-jina-rerank
|
Hey team, is there any timeline for the review of this PR? FYI @baskaryan |
baskaryan
approved these changes
Apr 17, 2024
dosubot
bot
added
the
lgtm
auto-merge was automatically disabled
April 22, 2024 07:25
Head branch was pushed to by a user without write access
|
Hey @baskaryan , is there anything missing for this to be merged? |
|
Merged, thank you @JoanFM! |
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
- **Description:** Adapt JinaEmbeddings to run with the new Jina AI Rerank API - **Twitter handle:** https://twitter.com/JinaAI_ - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ --------- Co-authored-by: Bagatur <[email protected]> Co-authored-by: Bagatur <[email protected]>
pprados
pushed a commit
to pprados/langchain
that referenced
this pull request
Apr 26, 2024
…i#19406) - **Description:** Adapt JinaEmbeddings to run with the new Jina AI Rerank API - **Twitter handle:** https://twitter.com/JinaAI_ - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ --------- Co-authored-by: Bagatur <[email protected]> Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adapt JinaEmbeddings to run with the new Jina AI Rerank API
Twitter handle: https://twitter.com/JinaAI_
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrationsdirectory.Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/