community[minor]: Add indexing via locality sensitive hashing to the Yellowbrick vector store #20856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markcusack
commented
Apr 24, 2024
markcusack
commented
- Description: Add LSH-based indexing to the Yellowbrick vector store module
- Twitter handle: @markcusack
A module that allows a Yellowbrick data warehouse instance to function as a vector store
Tests for Yellowbrick data warehouse
Added support for the Yellowbrick data warehouse
baskaryan
approved these changes
May 2, 2024
dosubot
bot
added
the
lgtm
…d replacing with ON COMMIT DROP
eyurtsev
approved these changes
May 6, 2024
|
|
||
| if not isinstance(embedding, Embeddings): | ||
| warnings.warn("embeddings input must be Embeddings object.") | ||
| self.logger.error("embeddings input must be Embeddings object.") |
There was a problem hiding this comment.
Wy does this not raise an exception?
| @@ -189,16 +408,110 @@ def from_texts( | |||
| table: table to store embeddings | |||
| kwargs: vectorstore specific parameters | |||
There was a problem hiding this comment.
new arguments are not documented
| ) | ||
| cursor.execute(query) | ||
|
|
||
| return None |
There was a problem hiding this comment.
nit: it's common to use an implicit return when the function is not meant to return anything (not important)
| def __init__( | ||
| self, | ||
| embedding: Embeddings, | ||
| connection_string: str, | ||
| table: str, | ||
| *, | ||
| schema: Optional[str] = None, |
|
|
||
| def create_table_if_not_exists(self) -> None: |
There was a problem hiding this comment.
fyi this is a breaking change since it was a public method
eyurtsev
changed the title
|
Left a few comment -- feel free to address in a separate PR if you think they're important. Merging as soon as tests pass. |
dglogo
pushed a commit
to dglogo/langchain
that referenced
this pull request
May 8, 2024
…Yellowbrick vector store (langchain-ai#20856) - **Description:** Add LSH-based indexing to the Yellowbrick vector store module - **Twitter handle:** @markcusack --------- Co-authored-by: markcusack <[email protected]> Co-authored-by: markcusack <[email protected]> Co-authored-by: Eugene Yurtsev <[email protected]>
kyle-cassidy
pushed a commit
to kyle-cassidy/langchain
that referenced
this pull request
May 10, 2024
…Yellowbrick vector store (langchain-ai#20856) - **Description:** Add LSH-based indexing to the Yellowbrick vector store module - **Twitter handle:** @markcusack --------- Co-authored-by: markcusack <[email protected]> Co-authored-by: markcusack <[email protected]> Co-authored-by: Eugene Yurtsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.