langchain: summarize chain fix
#21266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
size:L
ccurme
approved these changes
May 3, 2024
dosubot
bot
added
the
lgtm
|
@ccurme Thanks! |
This was referenced May 3, 2024
ccurme
pushed a commit
that referenced
this pull request
May 6, 2024
Issue: `load_qa_chain` is placed in the __init__.py file. As a result, it is not listed in the API Reference docs. BTW `load_qa_chain` is heavily presented in the doc examples, but is missed in API Ref. Change: moved code from init.py into a new file. Related: #21266
dglogo
pushed a commit
to dglogo/langchain
that referenced
this pull request
May 8, 2024
Issue: `load_qa_chain` is placed in the __init__.py file. As a result, it is not listed in the API Reference docs. BTW `load_qa_chain` is heavily presented in the doc examples, but is missed in API Ref. Change: moved code from init.py into a new file. Related: langchain-ai#21266
kyle-cassidy
pushed a commit
to kyle-cassidy/langchain
that referenced
this pull request
May 10, 2024
Issue: `load_qa_chain` is placed in the __init__.py file. As a result, it is not listed in the API Reference docs. BTW `load_qa_chain` is heavily presented in the doc examples, but is missed in API Ref. Change: moved code from init.py into a new file. Related: langchain-ai#21266
ccurme
pushed a commit
that referenced
this pull request
Jul 23, 2024
Issue: functions from `globals`, like the `get_debug` are placed in the init.py file. As a result, they don't listed in the API Reference docs. [See this](https://langchain-9jq1kef7i-langchain.vercel.app/v0.2/docs/how_to/debugging/#set_debugtrue) and [broken this](https://api.python.langchain.com/en/latest/globals/langchain.globals.set_debug.html). Change: moved code from init.py into the `globals.py` file and removed `globals` directory. Similar to: #21266 BTW `globals` in core implemented exactly inside a file not inside a folder.
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
Issue: functions from `globals`, like the `get_debug` are placed in the init.py file. As a result, they don't listed in the API Reference docs. [See this](https://langchain-9jq1kef7i-langchain.vercel.app/v0.2/docs/how_to/debugging/#set_debugtrue) and [broken this](https://api.python.langchain.com/en/latest/globals/langchain.globals.set_debug.html). Change: moved code from init.py into the `globals.py` file and removed `globals` directory. Similar to: langchain-ai#21266 BTW `globals` in core implemented exactly inside a file not inside a folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
load_summarize_chainis placed in the init.py file. As a result, it doesn't listed in the API Reference docs.Change: moved code from init.py into a new file.