Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai[patch]: fix tool calling token counting #23408

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

baskaryan
Copy link
Collaborator

@baskaryan baskaryan commented Jun 25, 2024

Resolves #23388

@efriis efriis added the partner label Jun 25, 2024
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:30pm

@efriis efriis self-assigned this Jun 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Jun 25, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 25, 2024
@ccurme
Copy link
Collaborator

ccurme commented Jun 25, 2024

Resolves #23388

@baskaryan baskaryan added the 02 regression Broke something that used to work. Fix should implement unit test. label Jun 25, 2024
@baskaryan baskaryan merged commit 9d145b9 into master Jun 25, 2024
42 checks passed
@baskaryan baskaryan deleted the bagatur/fix_token_counting branch June 25, 2024 17:34
mandos21 pushed a commit to mandos21/langchain that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 regression Broke something that used to work. Fix should implement unit test. 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] ChatOpenAI.get_num_tokens_from_messages breaks with tool calls since version 0.1.9
3 participants